Implement several utility trait #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamsi
reviewed
Nov 28, 2019
tendermint/src/lite/types.rs
Outdated
| @@ -102,6 +102,7 @@ pub trait Vote { | |||
| fn signature(&self) -> &[u8]; | |||
| } | |||
|
|
|||
| #[derive(Debug)] | |||
There was a problem hiding this comment.
Didn't this change already make into lite_impl_simple_merkle_merged via 9e00e99#diff-b1b6c7ff77dbf13838f76b8403715185?
There was a problem hiding this comment.
My mistake, just rebased this PR, only one line of change left.
yihuang
force-pushed
the
impl-utility-traits
branch
from
226ee38
to
517068b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DebugofErroris for printing error.Serialize/Deserializeofvalidator::Setis because it's a part of the trusted state, which needs to be stored somewhere.