Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tx_search endpoint for RPC client #701

Merged
merged 10 commits into from
Dec 1, 2020
Merged

Add tx_search endpoint for RPC client #701

merged 10 commits into from
Dec 1, 2020

Conversation

thanethomson
Copy link
Member

@thanethomson thanethomson commented Nov 24, 2020

Closes #698

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson marked this pull request as ready for review November 24, 2020 20:15
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Copy link
Member

@greg-szabo greg-szabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good.
I'm happy to see the correct use of our slightly messy serialization solution :) and I'm even happier to see rpc-probe in action.

Tokio might need some more cleanup or fixes according to the CI. I'll run through it again once the CI issues are fixed.

proto/src/serializers/bytes.rs Outdated Show resolved Hide resolved
thanethomson and others added 2 commits November 24, 2020 16:52
Co-authored-by: Greg Szabo <16846635+greg-szabo@users.noreply.github.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
melekes
melekes previously approved these changes Nov 25, 2020
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tendermint/tests/integration.rs Outdated Show resolved Hide resolved
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@ancazamfir
Copy link
Contributor

Looks good, I was able to get the tx info for IBC packets! Some small issue with the event key/ value encoding but orthogonal.
Thanks Thane!!

ancazamfir
ancazamfir previously approved these changes Nov 30, 2020
Copy link
Contributor

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked at the code in a lot of detail but I was able to integrate with this in IBC so for me it's good to go 👍 Thanks Thane!!

Signed-off-by: Thane Thomson <connect@thanethomson.com>
@cargo-dep-bot
Copy link

cargo-dep-bot bot commented Nov 30, 2020

This PR made the following dependency changes:

Added Packages (Duplicate versions in '()'):
	aead 0.3.2
	chacha20 0.6.0
	chacha20poly1305 0.7.1
	cipher 0.2.5
	crypto-mac 0.10.0
	eyre 0.6.3
	h2 0.2.7 (0.1.26)
	hkdf 0.10.0
	hmac 0.10.1
	indenter 0.3.0
	keccak 0.1.0
	merlin 2.0.0
	mio-named-pipes 0.1.7
	pin-project 0.4.27 (1.0.2)
	pin-project-internal 0.4.27 (1.0.2)
	pin-project-lite 0.1.11 (0.2.0)
	poly1305 0.6.1
	tendermint-p2p 0.17.0-rc3
	tokio-util 0.3.1
	tracing-futures 0.2.4
	universal-hash 0.4.0
	x25519-dalek 1.1.0

Removed Packages (Remaining versions in '()'):
	bytes 0.6.0 (0.5.6, 0.4.12)
	mio 0.7.6 (0.6.22)
	ntapi 0.3.6

Updated Packages:
	async-tungstenite: 0.10.0 -> 0.9.3
	http-body: 0.4.0 -> 0.3.1
	hyper: 0.14.0-dev -> 0.13.9
	tokio: 0.3.4 -> 0.2.23
	tokio-macros: 0.3.1 -> 0.2.6

@thanethomson thanethomson merged commit 25f7ba5 into master Dec 1, 2020
@thanethomson thanethomson deleted the rpc/tx_search branch December 1, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tx_search RPC
4 participants