Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tendermint-p2p crate #716

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Release tendermint-p2p crate #716

merged 2 commits into from
Nov 30, 2020

Conversation

thanethomson
Copy link
Member

Follows on from #715. We need a README.md in the crate before we can publish to crates.io.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

Signed-off-by: Thane Thomson <connect@thanethomson.com>
@codecov-io
Copy link

codecov-io commented Nov 30, 2020

Codecov Report

Merging #716 (c9cede9) into master (5757591) will not change coverage.
The diff coverage is 0.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #716   +/-   ##
======================================
  Coverage    40.1%   40.1%           
======================================
  Files         200     200           
  Lines       12680   12680           
  Branches     3185    3185           
======================================
  Hits         5096    5096           
  Misses       7261    7261           
  Partials      323     323           
Impacted Files Coverage Δ
p2p/src/secret_connection/protocol.rs 0.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5757591...c9cede9. Read the comment docs.

melekes
melekes previously approved these changes Nov 30, 2020
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we address the warnings before releasing?

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together!

⚾️ 👲 🕗 🏎

@thanethomson thanethomson merged commit e334fb7 into master Nov 30, 2020
@thanethomson thanethomson deleted the thane/release-p2p branch November 30, 2020 15:12
@thanethomson
Copy link
Member Author

Sure thing! It's up now: https://crates.io/crates/tendermint-p2p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants