Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ABCI crate #728

Closed
wants to merge 4 commits into from
Closed

Add ABCI crate #728

wants to merge 4 commits into from

Conversation

thanethomson
Copy link
Member

Closes #29

This PR contains experimental code that has slightly different aims to the other ABCI crates. I'll elaborate further as I've got more code.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

…s and unnecessary imports

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@codecov-io
Copy link

Codecov Report

Merging #728 (9de5b8d) into master (68bb2e8) will increase coverage by 0.9%.
The diff coverage is 85.8%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #728     +/-   ##
========================================
+ Coverage    42.7%   43.7%   +0.9%     
========================================
  Files         202     205      +3     
  Lines       12858   12889     +31     
  Branches     3223    3365    +142     
========================================
+ Hits         5496    5635    +139     
+ Misses       7014    6904    -110     
- Partials      348     350      +2     
Impacted Files Coverage Δ
abci/src/result.rs 0.0% <0.0%> (ø)
proto/src/lib.rs 76.3% <ø> (ø)
abci/src/protocol/abci.rs 84.6% <84.6%> (ø)
abci/src/protocol/tsp.rs 88.8% <88.8%> (ø)
abci/src/lib.rs 100.0% <100.0%> (ø)
tendermint/src/public_key.rs 55.8% <0.0%> (-5.5%) ⬇️
light-client/src/components/verifier.rs 91.1% <0.0%> (-3.0%) ⬇️
light-node/src/rpc.rs 52.0% <0.0%> (-1.5%) ⬇️
light-client/tests/light_client.rs 86.0% <0.0%> (-1.3%) ⬇️
tendermint/src/account.rs 79.0% <0.0%> (-1.3%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68bb2e8...9de5b8d. Read the comment docs.

@thanethomson
Copy link
Member Author

I'm closing this PR in favour of another one I've been working on (for simplicity of review).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Absorb rust-abci
2 participants