Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added version information to protobuf structs #733

Merged
merged 2 commits into from
Dec 11, 2020

Conversation

greg-szabo
Copy link
Member

@greg-szabo greg-szabo commented Dec 10, 2020

A minor enhancement that allows the tendermint-proto crate users to check what the source of the protobuf structs are.

tendermint_proto::meta::REPOSITORY and tendermint_proto::meta::COMMITISH are autogenerated constants when creating the structs.

Edit: it also fixes a random issue with git2::Oid::from_str(). It didn't surface before and it might be a bug in the patch version of git2 but this way it's slightly more robust.

Edit2: This is in preparation for the final Go v0.34.0-compatible Tendermint-rs v0.17.0. There will be another PR where we update the version number and fix the breaking changes.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

@codecov-io
Copy link

Codecov Report

Merging #733 (614a099) into master (d3d16be) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #733   +/-   ##
======================================
  Coverage    42.5%   42.5%           
======================================
  Files         202     202           
  Lines       12905   12905           
  Branches     3298    3298           
======================================
  Hits         5496    5496           
  Misses       7059    7059           
  Partials      350     350           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3d16be...614a099. Read the comment docs.

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@greg-szabo greg-szabo merged commit 2b9ea0f into master Dec 11, 2020
@greg-szabo greg-szabo deleted the greg/protobuf-versioning branch December 11, 2020 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants