Added version information to protobuf structs #733
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor enhancement that allows the
tendermint-proto
crate users to check what the source of the protobuf structs are.tendermint_proto::meta::REPOSITORY
andtendermint_proto::meta::COMMITISH
are autogenerated constants when creating the structs.Edit: it also fixes a random issue with
git2::Oid::from_str()
. It didn't surface before and it might be a bug in the patch version of git2 but this way it's slightly more robust.Edit2: This is in preparation for the final Go v0.34.0-compatible Tendermint-rs v0.17.0. There will be another PR where we update the version number and fix the breaking changes.