Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] Added signed transactions to gaiad #736

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Conversation

greg-szabo
Copy link
Member

@greg-szabo greg-szabo commented Dec 12, 2020

Prerequisite to #723.

A little extension to the gaiad docker image: two wallets were added to the genesis file and offline transactions were created and signed between them. This allows rpc-probe to submit a transaction to the network and then create feature-rich regular RPC endpoint queries to test structs.

rpc-probe should have the following steps for testing fully populated blocks:

  • locate the signed transaction in n0/c0-c1-signed.json
  • Submit it to localhost:1317/txs with a POST HTTP request
  • gather the Height from the response
  • Submit a /block?height=<gathered_height> request to the regular RPC.

The returned block will have all fields populated and it will be easier to test the struct compatibility.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

@codecov-io
Copy link

Codecov Report

Merging #736 (af9b5e4) into master (2b9ea0f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #736   +/-   ##
======================================
  Coverage    42.6%   42.6%           
======================================
  Files         203     203           
  Lines       12948   12948           
  Branches     3326    3326           
======================================
  Hits         5524    5524           
  Misses       7074    7074           
  Partials      350     350           
Impacted Files Coverage Δ
rpc/src/result.rs 27.6% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b9ea0f...af9b5e4. Read the comment docs.

@greg-szabo greg-szabo changed the title Added signed transactions to gaiad [docker] Added signed transactions to gaiad Dec 13, 2020
@thanethomson thanethomson merged commit a5c228f into master Dec 15, 2020
@thanethomson thanethomson deleted the greg/gaia-txs branch December 15, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants