Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final protobuf for 0.17.0 / Go 0.34.0 #737

Merged
merged 11 commits into from
Dec 14, 2020
Merged

Conversation

greg-szabo
Copy link
Member

@greg-szabo greg-szabo commented Dec 12, 2020

This is the final version of the protobuf structs in Tendermint Go 0.34.0.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

@greg-szabo greg-szabo added this to the v0.17.0 milestone Dec 12, 2020
@greg-szabo greg-szabo marked this pull request as ready for review December 14, 2020 18:43
@codecov-io
Copy link

codecov-io commented Dec 14, 2020

Codecov Report

Merging #737 (847b95d) into master (56d7e49) will decrease coverage by 0.0%.
The diff coverage is 28.2%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #737     +/-   ##
========================================
- Coverage    43.5%   43.5%   -0.1%     
========================================
  Files         203     203             
  Lines       13163   13171      +8     
  Branches     3470    3476      +6     
========================================
- Hits         5737    5736      -1     
- Misses       7073    7080      +7     
- Partials      353     355      +2     
Impacted Files Coverage Δ
p2p/src/secret_connection.rs 0.0% <ø> (ø)
proto-compiler/src/constants.rs 0.0% <ø> (ø)
tendermint/src/block/commit.rs 93.3% <ø> (-0.5%) ⬇️
tendermint/src/error.rs 50.0% <ø> (ø)
testgen/src/consensus.rs 0.0% <ø> (ø)
tendermint/src/public_key.rs 54.9% <8.3%> (-1.0%) ⬇️
tendermint/src/evidence.rs 27.8% <25.0%> (-1.4%) ⬇️
tendermint/src/validator.rs 57.2% <66.6%> (-0.5%) ⬇️
tendermint/src/abci/transaction.rs 58.9% <100.0%> (+1.5%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56d7e49...847b95d. Read the comment docs.

Copy link
Member

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks Greg! Looks good 👍

@thanethomson thanethomson merged commit 474091a into master Dec 14, 2020
@thanethomson thanethomson deleted the greg/protobuf-0.34.0 branch December 14, 2020 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants