Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.17.0 #751

Merged
merged 19 commits into from
Dec 17, 2020
Merged

Release v0.17.0 #751

merged 19 commits into from
Dec 17, 2020

Conversation

thanethomson
Copy link
Member

@thanethomson thanethomson commented Dec 16, 2020

📖 CHANGELOG

📖 New "Releases" section in contributing guidelines

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson marked this pull request as ready for review December 16, 2020 21:51
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@tony-iqlusion
Copy link
Collaborator

Is it still possible to get one last minute change in?

I'd like to cut another breaking release of the k256 crate later today and bump it again, similar to #724

greg-szabo
greg-szabo previously approved these changes Dec 16, 2020
Copy link
Member

@greg-szabo greg-szabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned in our discussion, I would rather have a 0.16.0 -> 0.17.0 full changelog on top of the rc release changelogs (we should keep those too), just so we see all the changes going into the new release but it's just a personal preference.

Thanks for the doctest improvements and the contribution file additions!

@codecov-io
Copy link

codecov-io commented Dec 16, 2020

Codecov Report

Merging #751 (70dc631) into master (462eafc) will decrease coverage by 1.1%.
The diff coverage is 61.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #751     +/-   ##
========================================
- Coverage    43.3%   42.1%   -1.2%     
========================================
  Files         203     206      +3     
  Lines       13169   13945    +776     
  Branches     3483    3571     +88     
========================================
+ Hits         5705    5876    +171     
- Misses       7104    7695    +591     
- Partials      360     374     +14     
Impacted Files Coverage Δ
light-client/src/lib.rs 100.0% <ø> (ø)
light-client/src/supervisor.rs 28.6% <ø> (ø)
light-node/src/lib.rs 100.0% <ø> (ø)
proto/src/lib.rs 76.3% <ø> (ø)
rpc-probe/src/kvstore.rs 0.0% <0.0%> (ø)
rpc-probe/src/quick.rs 0.0% <0.0%> (ø)
rpc/src/client.rs 7.2% <0.0%> (-0.3%) ⬇️
rpc/src/serialization.rs 0.0% <0.0%> (ø)
tendermint/src/lib.rs 100.0% <ø> (ø)
tendermint/tests/integration.rs 0.3% <0.0%> (-0.1%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 907cbc6...70dc631. Read the comment docs.

ebuchman
ebuchman previously approved these changes Dec 17, 2020
Copy link
Member

@ebuchman ebuchman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work.

@tony-iqlusion
Copy link
Collaborator

I opened a PR to bump the k256 crate to the latest v0.7 release: #752

If it's possible to get that PR into this release, that'd be great!

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
greg-szabo
greg-szabo previously approved these changes Dec 17, 2020
Copy link
Member

@greg-szabo greg-szabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff. Made some suggestions to make it a bit more concise but they're not that important.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Greg Szabo <16846635+greg-szabo@users.noreply.github.com>
thanethomson and others added 4 commits December 17, 2020 09:35
Co-authored-by: Greg Szabo <16846635+greg-szabo@users.noreply.github.com>
Co-authored-by: Greg Szabo <16846635+greg-szabo@users.noreply.github.com>
Co-authored-by: Greg Szabo <16846635+greg-szabo@users.noreply.github.com>
greg-szabo
greg-szabo previously approved these changes Dec 17, 2020
Signed-off-by: Thane Thomson <connect@thanethomson.com>
…inuing

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Copy link
Member

@greg-szabo greg-szabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script looks good. I like that it has a timeout.

@thanethomson thanethomson merged commit 27b3b73 into master Dec 17, 2020
@thanethomson thanethomson deleted the release/v0.17.0 branch December 17, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants