Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature-guard the sled light store and hide the dependency on sled #772

Merged
merged 4 commits into from
Jan 11, 2021

Conversation

romac
Copy link
Member

@romac romac commented Jan 5, 2021

See: #430 (comment)

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

@romac romac changed the title light-client: Feature-guard the sled light store and hide the dependency on sled Feature-guard the sled light store and hide the dependency on sled Jan 5, 2021
@romac romac added the light-client Issues/features which involve the light client label Jan 5, 2021
@romac romac marked this pull request as ready for review January 8, 2021 10:20
@codecov-io
Copy link

Codecov Report

Merging #772 (68d7b5c) into master (e65337a) will not change coverage.
The diff coverage is 0.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #772   +/-   ##
======================================
  Coverage    50.6%   50.6%           
======================================
  Files         197     197           
  Lines       13567   13567           
  Branches     3249    3247    -2     
======================================
  Hits         6869    6869           
  Misses       6336    6336           
  Partials      362     362           
Impacted Files Coverage Δ
light-client/examples/light_client.rs 0.0% <0.0%> (ø)
light-client/src/store.rs 52.0% <ø> (ø)
light-client/src/store/sled.rs 0.0% <0.0%> (ø)
light-node/src/commands/initialize.rs 0.0% <0.0%> (ø)
light-node/src/commands/start.rs 0.0% <0.0%> (ø)
light-client/src/macros.rs 15.2% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e65337a...68d7b5c. Read the comment docs.

@romac romac requested review from xla and liamsi January 8, 2021 23:12
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to look at some Rust code for a change :-)

LGTM

Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍁 ✴️ 🎤 🚚

@romac romac merged commit 2381dcf into master Jan 11, 2021
@romac romac deleted the romac/sled-feature branch January 11, 2021 11:33
romac added a commit that referenced this pull request Jan 11, 2021
… sled (#772)"

This reverts commit 2381dcf.

This change should not be part of the upcoming 0.17.1 tendermint-rs release.
@romac romac mentioned this pull request Jan 11, 2021
5 tasks
thanethomson pushed a commit that referenced this pull request Jan 11, 2021
… sled (#772)" (#780)

This reverts commit 2381dcf.

This change should not be part of the upcoming 0.17.1 tendermint-rs release.
@romac romac restored the romac/sled-feature branch January 11, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
light-client Issues/features which involve the light client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants