Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature-guard the sled light store and make the dependency on sled internal #781

Merged
merged 4 commits into from
Jan 11, 2021
Merged

Feature-guard the sled light store and make the dependency on sled internal #781

merged 4 commits into from
Jan 11, 2021

Conversation

romac
Copy link
Member

@romac romac commented Jan 11, 2021

See: #430 (comment)

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

@thanethomson thanethomson merged commit 589a3b1 into master Jan 11, 2021
@thanethomson thanethomson deleted the romac/sled-feature branch January 11, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanethomson thanethomson thanethomson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romac @thanethomson