Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Represent last_commit as Option<Commit> #79

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Nov 28, 2019

No description provided.

Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least a brief description that motivates the changes would be cool next time :-) (even if this a PR isn't to master). Something along the lines of:

Without these changes parsing an rpc response with an empty last_commit (e.g. on the first block), would err.

I've tested this locally... CI still doesn't run for PRs from forks :-/
Thanks again @yihuang!

@liamsi liamsi merged commit 22e4b6e into informalsystems:lite_impl_simple_merkle_merged Nov 28, 2019
@yihuang
Copy link
Contributor Author

yihuang commented Nov 28, 2019

At least a brief description that motivates the changes would be cool next time :-) (even if this a PR isn't to master). Something along the lines of:

Without these changes parsing an rpc response with an empty last_commit (e.g. on the first block), would err.

I've tested this locally... CI still doesn't run for PRs from forks :-/
Thanks again @yihuang!

Thanks, next time, I'll write some description ;D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants