Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ABCI integration test for minimal ABCI crate #797

Merged

Conversation

thanethomson
Copy link
Member

Builds on #794 by adding a small Rust-based tool to execute a bunch of transactions against a running Tendermint node, where the Tendermint node's connected to the kvstore-rs ABCI app.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Created abci test harness

* cargo make additions and docs
@thanethomson thanethomson marked this pull request as ready for review February 2, 2021 19:49
@@ -1,6 +1,7 @@
[workspace]

members = [
"abci-test",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this now, in a follow-up PR, I'd like to replace the abci-test crate with the same kvstore-test that we use for testing Tendermint RPC compatibility. It'll take some more extensive testing, however, and this test does the job for now.

@thanethomson thanethomson merged commit b429e5b into thane/minimal-blocking-abci Feb 9, 2021
@thanethomson thanethomson deleted the thane/abci-integration-test branch February 9, 2021 14:35
brapse pushed a commit that referenced this pull request Feb 19, 2021
* Add minimal blocking ABCI library

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Expand API to implement in-memory key/value store app

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add kvstore-rs ABCI app

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add rudimentary README

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Bump proto version dependency to v0.18.0

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Replace manual default structs with Default::default()

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Enable debug logging for all incoming ABCI requests

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Improve CLI UX

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Allow for read buffer size customization

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add crate description

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Update README for ABCI crate

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add ABCI integration test for minimal ABCI crate (#797)

* Add integration testing utility for ABCI key/value store

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add hacky bash script to demonstrate parallel execution

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Created abci test harness (#800)

* Created abci test harness

* cargo make additions and docs

Co-authored-by: Greg Szabo <16846635+greg-szabo@users.noreply.github.com>

* Update abci/src/codec.rs

Co-authored-by: Romain Ruetschi <romain@informal.systems>

* Apply suggestion from #794

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Refactor error handing and expose eyre::Result as crate default Result type

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Refactor to use tracing instead of log

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add newline

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Remove comment relating to constraints on Codec struct params

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Version tendermint-abci crate in line with other tendermint-rs crates

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Update CHANGELOG

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Expand crate documentation

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Extract request dispatch functionality from Application trait

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Move ABCI server example to crate root

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Fix broken link in docs

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Replace EchoApp example with KeyValueStoreApp example

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Co-authored-by: Greg Szabo <16846635+greg-szabo@users.noreply.github.com>
Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants