Add TLS support for the Light Client #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thane Thomson <connect@thanethomson.com>
This commit adds pagination to the `validators` method on the `Client` trait (BREAKING). Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
… string (like page numbers/per page counts) Signed-off-by: Thane Thomson <connect@thanethomson.com>
…from strings first Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Codecov Report
@@ Coverage Diff @@
## thane/831-validators-hash #842 +/- ##
===========================================================
Coverage ? 28.8%
===========================================================
Files ? 196
Lines ? 10886
Branches ? 4495
===========================================================
Hits ? 3136
Misses ? 4773
Partials ? 2977 Continue to review full report at Codecov.
|
romac
requested changes
Mar 29, 2021
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
romac
approved these changes
Mar 29, 2021
thanethomson
added a commit
that referenced
this pull request
Mar 30, 2021
* Remove unused file Signed-off-by: Thane Thomson <connect@thanethomson.com> * Refactor validators RPC endpoint interface This commit adds pagination to the `validators` method on the `Client` trait (BREAKING). Signed-off-by: Thane Thomson <connect@thanethomson.com> * Ensure "total" response field is a string Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add serializer for optional types that need to be converted to/from a string (like page numbers/per page counts) Signed-off-by: Thane Thomson <connect@thanethomson.com> * Refactor to ensure page numbers and per-page values are converted to/from strings first Signed-off-by: Thane Thomson <connect@thanethomson.com> * Convert tcp:// scheme to http:// for RPC addresses Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add Light Client support for RPC URLs instead of net::Address Signed-off-by: Thane Thomson <connect@thanethomson.com> * Revert 14ad69f for now Signed-off-by: Thane Thomson <connect@thanethomson.com> * Revert f0c26f7 Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add CHANGELOG Signed-off-by: Thane Thomson <connect@thanethomson.com> * Convert tcp:// scheme to http:// for RPC addresses Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add Light Client support for RPC URLs instead of net::Address Signed-off-by: Thane Thomson <connect@thanethomson.com> * Comment not needed Signed-off-by: Thane Thomson <connect@thanethomson.com> * Expose rpc::Url type Signed-off-by: Thane Thomson <connect@thanethomson.com> * Update kvstore integration test to use rpc::Url Signed-off-by: Thane Thomson <connect@thanethomson.com> * Update CHANGELOG Signed-off-by: Thane Thomson <connect@thanethomson.com> * Remove debug output from height log Signed-off-by: Thane Thomson <connect@thanethomson.com> * Attach serialization directly to tendermint_rpc::Url Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add some happy path tests for tendermint_rpc::Url parsing Signed-off-by: Thane Thomson <connect@thanethomson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #835.
It additionally introduces a little more info-level logging in the Light Node.
I've successfully manually tested the Light Node against two different Cosmos Hub validators, both accessed via HTTPS.