Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.19.0 #854

Merged
merged 9 commits into from
Apr 7, 2021
Merged

Release v0.19.0 #854

merged 9 commits into from
Apr 7, 2021

Conversation

thanethomson
Copy link
Member

@thanethomson thanethomson commented Apr 6, 2021

📖 CHANGELOG rendered

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson requested a review from romac April 6, 2021 15:24
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson marked this pull request as draft April 6, 2021 15:39
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson marked this pull request as ready for review April 6, 2021 15:42
romac
romac previously approved these changes Apr 6, 2021
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson marked this pull request as draft April 6, 2021 21:19
@thanethomson
Copy link
Member Author

Converting this back to draft for now until I resolve the rust-peg issue in the tendermint-rpc crate 😞

Adds a method which repeatedly polls the `/health` endpoint until it
returns a successful response or a specified timeout elapses.

This is useful when writing tests that need to wait for a node to boot
up (e.g. inside of a docker container).
@codecov-io
Copy link

Codecov Report

Merging #854 (2cdab92) into master (d1c8877) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #854   +/-   ##
======================================
  Coverage    67.1%   67.1%           
======================================
  Files         211     211           
  Lines       17026   17030    +4     
======================================
+ Hits        11427   11430    +3     
- Misses       5599    5600    +1     
Impacted Files Coverage Δ
light-client/src/lib.rs 100.0% <ø> (ø)
light-node/src/lib.rs 100.0% <ø> (ø)
p2p/src/lib.rs 100.0% <ø> (ø)
proto/src/lib.rs 100.0% <ø> (ø)
rpc/src/client.rs 16.9% <ø> (ø)
tendermint/src/lib.rs 100.0% <ø> (ø)
light-client-js/src/lib.rs 6.6% <100.0%> (ø)
rpc/src/endpoint/genesis.rs 40.0% <0.0%> (-60.0%) ⬇️
rpc/src/endpoint/health.rs 20.0% <0.0%> (-30.0%) ⬇️
tendermint/src/signature.rs 56.4% <0.0%> (-4.2%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1c8877...2cdab92. Read the comment docs.

thanethomson and others added 2 commits April 6, 2021 20:18
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson marked this pull request as ready for review April 7, 2021 00:30
@thanethomson thanethomson merged commit 2609b60 into master Apr 7, 2021
@thanethomson thanethomson deleted the release/v0.19.0 branch April 7, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants