Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tempdir dependency with tempfile #883

Merged
merged 5 commits into from
Jun 5, 2021
Merged

Conversation

thanethomson
Copy link
Member

Closes #851

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson requested a review from romac May 18, 2021 20:33
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2021

Codecov Report

Merging #883 (bfb8607) into master (b032801) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #883     +/-   ##
========================================
- Coverage    69.8%   69.7%   -0.1%     
========================================
  Files         200     200             
  Lines       16314   16322      +8     
========================================
- Hits        11393   11390      -3     
- Misses       4921    4932     +11     
Impacted Files Coverage Δ
light-client/src/store/sled.rs 77.0% <100.0%> (ø)
light-client/src/store/sled/utils.rs 65.0% <100.0%> (ø)
tendermint/src/signature.rs 56.4% <0.0%> (-4.2%) ⬇️
light-client/src/types.rs 30.1% <0.0%> (-0.9%) ⬇️
testgen/src/header.rs 78.1% <0.0%> (-0.7%) ⬇️
testgen/src/vote.rs 83.7% <0.0%> (ø)
tendermint/src/node.rs 65.9% <0.0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b032801...bfb8607. Read the comment docs.

romac
romac previously approved these changes May 20, 2021
xla
xla previously approved these changes May 20, 2021
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(´ー`)

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson dismissed stale reviews from xla and romac via bfb8607 June 3, 2021 15:45
@thanethomson thanethomson requested a review from xla June 3, 2021 17:32
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗓 🍫 🏎 ✍

@thanethomson thanethomson merged commit 5475e95 into master Jun 5, 2021
@thanethomson thanethomson deleted the thane/851-tempdir branch June 5, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2018-0017: tempdir crate has been deprecated; use tempfile instead
4 participants