Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix latest clippy assertion failures #910

Merged
merged 11 commits into from
Jun 22, 2021
Merged

Fix latest clippy assertion failures #910

merged 11 commits into from
Jun 22, 2021

Conversation

thanethomson
Copy link
Member

@thanethomson thanethomson commented Jun 21, 2021 •
edited

Closes #909

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@thanethomson
Use idiomatic assertions
6282dae 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson
Fix self conventions
43c5734 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson
Rename Time::to_rfc3339 to Time::as_rfc3339 to fix self convention
314f166 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson
Remove unnecessary clones for Copy-able structs
1350773 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson
Use idiomatic assertions
2659f19 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson
Use std::mem::take, which already provides this functionality
4d3dcf3 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson
Use idiomatic assertions
7ec6408 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson
Reduce to more idiomatic form
27c18b0 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2021 •
edited

Codecov Report

Merging #910 (e034c49) into master (795e3bd) will decrease coverage by 0.0%.
The diff coverage is 86.2%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #910     +/-   ##
========================================
- Coverage    70.7%   70.7%   -0.1%     
========================================
  Files         203     203             
  Lines       16217   16222      +5     
========================================
- Hits        11478   11470      -8     
- Misses       4739    4752     +13
Impacted Files Coverage Δ
tendermint/src/serializers/time.rs 100.0% <ø> (ø)
tendermint/src/vote.rs 74.3% <0.0%> (ø)
test/src/pipe.rs 76.8% <33.3%> (ø)
tendermint/src/time.rs 93.2% <66.6%> (ø)
light-client/src/supervisor.rs 90.6% <100.0%> (-0.1%) ⬇️
proto/src/serializers/timestamp.rs 96.3% <100.0%> (ø)
proto/tests/unit.rs 90.3% <100.0%> (+1.6%) ⬆️
rpc/src/endpoint/consensus_state.rs 71.0% <100.0%> (ø)
rpc/tests/parse_response.rs 98.0% <100.0%> (ø)
tendermint/src/public_key.rs 67.5% <100.0%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 795e3bd...e034c49. Read the comment docs.

@thanethomson
Pin tokio versions to 1.6.2 until they fix broken docsrs config
53c1a50 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson
Rename to be consistent with Rust self conventions
c005d4d 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson
Add .changelog entry for API change
e034c49 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson requested a review from xla June 21, 2021 21:14
@thanethomson thanethomson marked this pull request as ready for review June 21, 2021 21:14
xla
xla approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚅 💧 🅿️ 🍣

light-client/Cargo.toml
@@ -51,7 +51,8 @@ serde_derive = "1.0.106"
sled = { version = "0.34.3", optional = true }
static_assertions = "1.1.0"
thiserror = "1.0.15"
tokio = { version = "1.0", features = ["rt"], optional = true }
# TODO(thane): Unpin this version once Tokio fixes the documentation compiling problem in v1.7+.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a tracking issue for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, just added #911 👍

@thanethomson thanethomson mentioned this pull request Jun 22, 2021
Closed
@thanethomson thanethomson merged commit 1b3464e into master Jun 22, 2021
@thanethomson thanethomson deleted the thane/909-fix-clippy branch June 22, 2021 11:04
thanethomson added a commit that referenced this pull request Jun 22, 2021
@thanethomson
Update .changelog to reflect incoming changes from #910
6d56ac9 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
thanethomson added a commit that referenced this pull request Jun 22, 2021
@thanethomson @xla
Release v0.20.0 (#912)
21ef18f 
* Fix changelog entry formatting

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add link to changelog entry

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Prepare v0.20.0 changelog

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Expand crate name for clarity

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Fix summary wording

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Fix missing closing brace

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Build changelog

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Remove tendermint-light-node from release script

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Bump versions to v0.20.0

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Update .changelog to reflect incoming changes from #910

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Remove superfluous breaking changes references

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Rebuild changelog

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add dates to releases

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Rebuild changelog

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Update .changelog/v0.20.0/summary.md

Co-authored-by: Alexander Simmerl <a.simmerl@gmail.com>

* Update .changelog/v0.20.0/summary.md

Co-authored-by: Alexander Simmerl <a.simmerl@gmail.com>

* Rebuild changelog

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Update .changelog/v0.20.0/summary.md

* Rebuild changelog

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Co-authored-by: Alexander Simmerl <a.simmerl@gmail.com>
@mzabaluev mzabaluev mentioned this pull request Nov 26, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xla xla xla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New clippy errors with Rust 1.53
3 participants
@thanethomson @codecov-commenter @xla