Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive PartialEq and Eq on more types #970

Merged
merged 5 commits into from
Sep 13, 2021
Merged

Derive PartialEq and Eq on more types #970

merged 5 commits into from
Sep 13, 2021

Conversation

romac
Copy link
Member

@romac romac commented Sep 9, 2021

Closes: #969

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2021

Codecov Report

Merging #970 (7d8807e) into master (b99c937) will increase coverage by 0.0%.
The diff coverage is 85.7%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #970   +/-   ##
======================================
  Coverage    72.1%   72.1%           
======================================
  Files         203     203           
  Lines       16589   16581    -8     
======================================
- Hits        11964   11962    -2     
+ Misses       4625    4619    -6     
Impacted Files Coverage Δ
rpc/src/error.rs 0.0% <0.0%> (ø)
tendermint/src/error.rs 0.0% <0.0%> (ø)
rpc/src/endpoint/abci_query.rs 21.4% <100.0%> (ø)
tendermint/src/block/commit.rs 96.8% <100.0%> (ø)
tendermint/src/block/commit_sig.rs 76.5% <100.0%> (-2.2%) ⬇️
tendermint/src/block/header.rs 99.1% <100.0%> (ø)
tendermint/src/block/signed_header.rs 91.6% <100.0%> (ø)
tendermint/src/hash.rs 36.8% <100.0%> (-1.0%) ⬇️
tendermint/src/signature.rs 56.6% <100.0%> (ø)
tendermint/src/validator.rs 69.2% <100.0%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b99c937...7d8807e. Read the comment docs.

@romac romac changed the title Derive Eq on SignedHeader and Commit Derive PartialEq and Eq on more types Sep 9, 2021
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1️⃣ 🍦 🧀 🏺

@thanethomson thanethomson merged commit 80559bd into master Sep 13, 2021
@thanethomson thanethomson deleted the romac/eq-bounds branch September 13, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Derive Eq on SignedHeader and Commit
5 participants