Add Bootstrap classes to Footer #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add links - Add more social media examples
infotexture
reviewed
Sep 6, 2023
.github/dita-ot/footer.xml
Outdated
Comment on lines
7
to
10
| <!-- Twitter --> | ||
| <a class="btn btn-primary m-1" href="" role="button"><i | ||
| class="bi bi-twitter" | ||
| /></a> |
There was a problem hiding this comment.
This creates a redundant Twitter link with no link target.
I'll push a new commit to remove it.
Amends 4e43070. Signed-off-by: Roger Sheen <roger@infotexture.net>
Signed-off-by: Roger Sheen <roger@infotexture.net>
Signed-off-by: Roger Sheen <roger@infotexture.net>
Signed-off-by: Roger Sheen <roger@infotexture.net>
Signed-off-by: Roger Sheen <roger@infotexture.net>
Amends a1406ae. Signed-off-by: Roger Sheen <roger@infotexture.net>
infotexture
force-pushed
the
feature/footer
branch
from
8d3db41
to
c917ce3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autostyle the
<footer>element using standard Bootstrap - e.g.simplexbootstrap.css.footerparamter