-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand utility classes #13
Conversation
Marked as Draft for now, as we'll want to rebase this onto 🤔 Not sure I get the intention of using attribute sets like in the PDF plug-in here. I think it's good to make things easier to customize, but doesn't this just change the file in which the values must be changed? |
6064a46
to
a6e4d64
Compare
a6e4d64
to
0e959de
Compare
I've had a rethink, and it looks like the existing DITA-OT The PR just collects all the relevant bootstrap CSS styles into one single file rather than scattering them across all the xsl stylesheets, which makes the values easier to maintain and update. |
For example, the "default" DITA Bootstrap uses ./dita -f html5-bootstrap \
-i ../plugins/dita-bootstrap/sample/document.ditamap \
--bootstrap.css.header=text-primary Example: Plugins for DITA Open Toolkit Similarly you can change the margins and add a border on all vertical tabbed dialogs with: ./dita -f html5-bootstrap \
-i ../plugins/dita-bootstrap/sample/document.ditamap \
--bootstrap.css.tabs.vertical="border m-5" Similarly, the "default" bootstrap uses rounded corners for boxes so the codeblocks should also be annotated with utility classes to provide rounded corners ./dita -f html5-bootstrap \
-i ../plugins/dita-bootstrap/sample/document.ditamap \
--bootstrap.css.codeblock=border |
Remove the need for duplicate outputclass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this was stuck in the review queue for so long, but I think the ability to pass additional Bootstrap classes via CLI parameters is useful, so I'll merge this. 👍
We'll probably want to add a few more examples to the README based on #13 (comment), but I can handle that along with the other release prep tasks in #12.
You might want to consider this as part of #12 once #11 has landed.
It splits out as many hard-coded magic numbers into an
<xsl:attribute-set>
in the same fashion as the PDF transform