fix: skeleton cannot dispaly without children

infra-fe · Apr 6, 2022 · 0b4a968 · 0b4a968
1 parent a67c0d2
commit 0b4a968
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/components/skeleton/Skeleton.tsx b/components/skeleton/Skeleton.tsx
@@ -161,7 +161,7 @@ const Skeleton = (props: SkeletonProps) => {
       </div>
     );
   }
-  return children as React.ReactElement;
+  return children ? children as React.ReactElement : null;
 };
 
 Skeleton.defaultProps = {

diff --git a/components/skeleton/__tests__/index.test.js b/components/skeleton/__tests__/index.test.js
@@ -34,6 +34,11 @@ describe('Skeleton', () => {
     expect(wrapperSmall.render()).toMatchSnapshot();
   });
 
+  it('should display without children', () => {
+    const wrapper = mount(<Skeleton loading={false}></Skeleton>);
+    expect(wrapper.render()).toMatchSnapshot();
+  });
+
   it('should display children', () => {
     const wrapper = mount(<Skeleton loading={false}>{[1, 2, 3]}</Skeleton>);
     expect(wrapper.text()).toBe('123');