Skip to content

Commit

Permalink
fix(geo): print - remove 300 PPI resolution (#1489)
Browse files Browse the repository at this point in the history
* fix(geo): print - remove 300 PPI resolution
- Add traduction for resolution unit measure
  • Loading branch information
alecarn committed Nov 7, 2023
1 parent 6ba33af commit 2f728da
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,11 @@

<div class="igo-input-container">
<mat-form-field>
<mat-label>{{ 'igo.geo.printForm.resolution' | translate }}</mat-label>
<mat-label
>{{ 'igo.geo.printForm.resolution' | translate }} ({{
'igo.geo.printForm.resolutionUnit' | translate
}})</mat-label
>
<mat-select
formControlName="resolution"
placeholder="{{ 'igo.geo.printForm.resolution' | translate }}"
Expand All @@ -190,7 +194,7 @@
*ngFor="let resolution of resolutions | keyvalue"
[value]="resolution.key"
>
{{ resolution.value + ' PPI' }}
{{ resolution.value }}
</mat-option>
</mat-select>
</mat-form-field>
Expand Down
2 changes: 1 addition & 1 deletion packages/geo/src/lib/print/shared/print.type.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export type PrintPaperFormat = keyof typeof PrintPaperFormat;
export const PrintOrientation = strEnum(['landscape', 'portrait']);
export type PrintOrientation = keyof typeof PrintOrientation;

export const PrintResolution = strEnum(['72', '96', '150', '300']);
export const PrintResolution = strEnum(['72', '96', '150']); // For now, we remove the 300 dpi because there is too much instability on iOS and slow device.
export type PrintResolution = keyof typeof PrintResolution;

export const PrintSaveImageFormat = strEnum([
Expand Down
1 change: 1 addition & 0 deletions packages/geo/src/locale/en.geo.json
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,7 @@
"portrait": "Portrait",
"projection": "Projection",
"resolution": "Resolution",
"resolutionUnit": "PPI",
"saveBtn": "Save",
"scale": "Scale",
"showProjection": "Show projection",
Expand Down
1 change: 1 addition & 0 deletions packages/geo/src/locale/fr.geo.json
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,7 @@
"portrait": "Portrait",
"projection": "Projection",
"resolution": "Résolution",
"resolutionUnit": "PPP",
"saveBtn": "Sauvegarder",
"scale": "Échelle",
"showProjection": "Afficher la projection",
Expand Down

0 comments on commit 2f728da

Please sign in to comment.