-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(query): redefine feature count and pop a message when limit … #1055
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose to change the message to something like that..
You have queried this layer. It's possible to have some remaining feature on the map. Zoom on map to ensure to have access to all features... Something like that (and better i hope)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved if the message is changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some issues to fix
@pelord ready to be tested again |
@PhilippeLafreniere18 how handle multiple layers.. a this moment, only the first layer show the message. |
#1055) * refactor(query): redefine fetaure count and pop a message when limit is exceeded * fix(query): fix custom feature count with multiple layers / test ngx translate * lint * fix(query): remove feature count message with another query * lint
…is exceeded
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
When query features exceed the feature count, nothing is triggered to the user
Default feature count is set to 5
What is the new behavior?
When query features exceed the feature count, an info message is displayed
Default feature count is set to 20
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: