refactor(query): redefine feature count and pop a message when limit … #1055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeLafreniere18
changed the title
pelord
requested changes
May 18, 2022
Member
pelord
left a comment
pelord
left a comment
There was a problem hiding this comment.
I propose to change the message to something like that..
You have queried this layer. It's possible to have some remaining feature on the map. Zoom on map to ensure to have access to all features... Something like that (and better i hope)
pelord
approved these changes
May 19, 2022
Member
pelord
left a comment
pelord
left a comment
There was a problem hiding this comment.
Approved if the message is changed.
Contributor
Author
|
@pelord ready to be tested again |
Member
|
@PhilippeLafreniere18 how handle multiple layers.. a this moment, only the first layer show the message. |
pelord
approved these changes
Jun 8, 2022
cbourget
pushed a commit
that referenced
this pull request
Mar 21, 2023
#1055) * refactor(query): redefine fetaure count and pop a message when limit is exceeded * fix(query): fix custom feature count with multiple layers / test ngx translate * lint * fix(query): remove feature count message with another query * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…is exceeded
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
When query features exceed the feature count, nothing is triggered to the user
Default feature count is set to 5
What is the new behavior?
When query features exceed the feature count, an info message is displayed
Default feature count is set to 20
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: