Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover feature #779

Merged
merged 7 commits into from
Nov 16, 2020
Merged

Hover feature #779

merged 7 commits into from
Nov 16, 2020

Conversation

matrottier
Copy link
Contributor

@matrottier matrottier commented Nov 13, 2020

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?
hover on vector layer

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:
tested with WFS (Point, Line and Polygon) and VectorTile (Polygon).
example added (WFS Point and Polygon)

@matrottier
Copy link
Contributor Author

the vector tile styling must have a merge of all features with the same id.
Tested with Turfjs but the installation was chaotic and had many errors
#TODO

@matrottier matrottier marked this pull request as ready for review November 16, 2020 12:32
@mbarbeau mbarbeau merged commit 7a19ffe into next Nov 16, 2020
@mbarbeau mbarbeau deleted the hover_feature branch November 16, 2020 19:55
mbarbeau added a commit that referenced this pull request Nov 16, 2020
* feat(vectorLayer) add a hover directive #773

* feat(layerVector.hover) add hover for layer vector and fix #765

* feat(map.hover) delete hover screen on single click

* feat (map.hover) fix lint

* Delete mapboxStyle-covid.json

no need ...

* Delete mapboxStyle-covidcomplet.json

no need ...

* Update hover-routing.module.ts

Co-authored-by: Marc-André Trottier <trottier.marcandre@msp.gouv.qc.ca>
Co-authored-by: Marc-André Barbeau <marc-andre.barbeau@msp.gouv.qc.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants