feat(geo): adding initial button component files #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneige
changed the title
|
Il manque les traductions associées au bouton dans les fichiers en.geo.json et fr.geo.json. Je me demande si on devrait pas le renommer... Initial-button me dit pas grand chose. |
|
Ma première idée était initial-extent. ça pourrait être map-extent |
|
Mais étant donné que de le bouton peut servir autant à un extent qu'à un centre avec niveau de zoom, seulement extent n'est peut-être pas adéquat ? Au final, il sert vraiment à bouger ou à recentrer ta carte active à un endroit prédéfinie. |
|
recenter-map ? |
PhilippeLafreniere18
approved these changes
Feb 14, 2022
packages/geo/src/lib/map/initial-button/initial-button.component.html
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/map/initial-button/initial-button.component.ts
Outdated
Show resolved
Hide resolved
|
@PhilippeLafreniere18 @mneige Any reviews? |
|
C'était bon pour moi ! Il manquait seulement la doc (assemblage) |
cbourget
pushed a commit
that referenced
this pull request
Mar 21, 2023
* adding initial button component files * correcting initialbutton * corrections to initial button * correction to initial button * Button name changed to home-extent-button * adding package.json as required * minors fix * fix package * refactor(home-extent-button): update with config * fix event parameter * feat(home-extent): allow to provide homeExtent properties from context Co-authored-by: Philippe Lafreniere <philippe.lafreniere@msp.gouv.qc.ca> Co-authored-by: Pierre-Etienne Lord
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
Missing button to return to initial extent of the map
What is the new behavior?
Added button to return to initial extent of the map
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: