Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script to create and destroy KIND cluster #320

Closed
PrasadG193 opened this issue Aug 3, 2020 · 4 comments · Fixed by #365
Closed

Add script to create and destroy KIND cluster #320

PrasadG193 opened this issue Aug 3, 2020 · 4 comments · Fixed by #365
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest test-framework

Comments

@PrasadG193
Copy link
Collaborator

PrasadG193 commented Aug 3, 2020 •
edited
Loading

Describe the solution you'd like

  • Create a script to create and destroy KIND clusters which can be used to execute test and CD jobs
  • Add make targets for the same.
  • Script can be placed under hacks dir
@PrasadG193 PrasadG193 added enhancement New feature or request test-framework labels Aug 3, 2020
@PrasadG193 PrasadG193 added the release-blocker Upcoming release is blocked by this issue label Aug 3, 2020
@PrasadG193 PrasadG193 removed the release-blocker Upcoming release is blocked by this issue label Sep 12, 2020
@PrasadG193 PrasadG193 changed the title Run e2e tests against KIND Add script to create and destroy KIND cluster Sep 28, 2020
@haardikdharma10
Copy link

Hey @PrasadG193, I'd like to help in solving this issue. However, I didn't get the second bullet point you have mentioned. Can you help me with it?

@PrasadG193
Copy link
Collaborator Author

Hi @haardikdharma10,
I meant Makefile, sorry for the confusion. So basically we should add a Makefile target e.g - make create-kind and make destroy-kind targets to create and destroy KIND cluster

@haardikdharma10
Copy link

Also, should I add 2 different scripts for each one of them or only one should work, for both creating and destroying?

@PrasadG193
Copy link
Collaborator Author

We can have 2 targets - create and delete in a single script. Something like - ./hack/kind.sh create & ./hack/kind.sh delete
Additionally good to have help target also e.g ./hack/kind.sh help which should be the default target as well.

@Abhishek627 Abhishek627 mentioned this issue Sep 30, 2020
Merged
@mergify mergify bot closed this as completed in #365 Oct 5, 2020
mergify bot pushed a commit that referenced this issue Oct 5, 2020
@Abhishek627
adding option to create and destroy kind clusters (#365)
af6a000 
##### ISSUE TYPE
 - Feature Pull Request

##### SUMMARY
Created a script to create and destroy KIND clusters which can be used to execute test and CD jobs. Added make targets for those and default make help.

Fixes #320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest test-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adding option to create and destroy kind clusters Abhishek627/botkube
2 participants
@PrasadG193 @haardikdharma10