Set Atlantis Docker tag

[7onn]

What do you expect to happen?
I think it would be nice if this project mirrored the Atlantis releases.

Why?
Because this way, any update in the Atlantis version would provide the same tag for this Infracost "plugin"

Sorry I didn't open an Issue first. I saw this one wondering about versioning the plugin itself but it also made sense to me just mirroring the Atlantis. Plus my request seemed trivial to implement and I'm ready to face denial if my suggestion didn't match the expectations 🤷🏼

[CLAassistant]

All committers have signed the CLA.

[7onn]

@alikhajeh1

[aliscott]

Thanks @7onn.

I wonder if we should tag in the following format? :<infracost-version>-<atlantis-version>, e.g.:

infracost/infracost-atlantis:latest-atlantis0.17.2

This is what I've seen with other docker images that also tag based on the base image, e.g. the redis image with alpine.

What do you think?

[7onn]

@aliscott It seems super reasonable.

But currently, there are no releases for infracost/infracost-atlantis 🤔 Only a workflow that triggers at every push to the main branch.

Do you mean the <infracost-version> to be the commit hash or a static latest? Because otherwise, I can add a workflow for handling the releases of it (and only push the docker release tag at this newest workflow while the latest keeps being pushed by the main branch HEAD). Then we would output something like v0.1.0-atlantisv0.17.2.

[aliscott]

Do you mean the to be the commit hash or a static latest?

I think a static latest at the moment is good. Then in the future I think we can add tags for specific Infracost CLI versions, e.g. 0.9.11-atlantis0.17.2. I don't think we need specific tags for the versions of this integration, so think tagging based on Infracost CLI version and atlantis version is good enough. What do you think?

[7onn]

I think a static latest at the moment is good.

Of course 🤦🏼 I did miss the fact that the Dockerfile currently pulls the latest Infracost version.

Done: 6972d03

[aliscott]

Thanks @7onn, I'd consider removing the v prefix as well. I think we probably want to make that change in the main Infracost repo as well going forward, the standard (from the other images I've checked) seems to be to drop the v in the Docker tag.

[7onn]

Thanks @7onn, I'd consider removing the v prefix as well. I think we probably want to make that change in the main Infracost repo as well going forward, the standard (from the other images I've checked) seems to be to drop the v in the Docker tag.

If you mean this v prefix, then I guess there's no problem because the regex would match any version number with or without it.

You may just change it in Dockerfile and the pattern will be considered by the create-release workflow.

[aliscott]

then I guess there's no problem because the regex would match any version number with or without it.

The runatlantis/atlantis image tags all have the v prefix, so we can't update the Dockerfile to remove this.

Most docker images I see don't use this prefix, so I was wondering if we should change to grep -oE '[0-9]+.[0-9]+.[0-9]+' to always exclude the v so this gets tagged as latest-atlantis0.17.2

[7onn]

There we go: c3ed42d

Here's the expected version output:

$ ATLANTIS_TAG=latest-atlantis$(cat Dockerfile | \
            grep -oE 'FROM.*atlantis.*' | \
            grep -oE '[0-9]+.[0-9]+.[0-9]+') 
&& echo $ATLANTIS_TAG
...
latest-atlantis0.17.2

[aliscott]

Thanks @7onn! I've added a PR to Infracost CLI as well to update the Docker tagging there based on this discussion: infracost/infracost#1070

[aliscott]

BOOM! 🚀 works beautifully: https://hub.docker.com/layers/infracost/infracost-atlantis/latest-atlantis0.17.2/images/sha256-d6bd446de662d82612ebf1a60e00cf81ac77e1de6081f8d0bab783c70dfd20bd?context=explore