Update docker tagging #1070
Merged
Update docker tagging #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we tag new version with: `:v0.9.11` and `:latest`. This updates it so we tag with `:0.9.11`, `:0.9`, and `:latest`. We remove the `v` prefix to be consistent with how other docker images are tagged.
|
LGTM. We should probably also close infracost/infracost-atlantis#10 and maybe update https://github.com/infracost/infracost-atlantis#usage-methods so "latest release, v0.9.11" becomes "latest release, v0.9" as we want users to use that so they get the patch updates. |
As far as I'm aware, this doesn't fix that. We've added tagging to the atlantis image based on the atlantis version in infracost/infracost-atlantis#15, but this doesn't tag based on the Infracost version yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: test this in next release if approved
Currently we tag new version with:
:v0.9.11and:latest. This updates it so we tag with:0.9.11,:0.9, and:latest. We remove thevprefix to be consistent with how other docker images are tagged.