Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CircleCI integration #56

Closed
alikhajeh1 opened this issue Sep 3, 2020 · 9 comments
Closed

Add CircleCI integration #56

alikhajeh1 opened this issue Sep 3, 2020 · 9 comments
Assignees
Labels
new integration New integration with external product/tool (CI/CD, code editor, etc)

Comments

@alikhajeh1
Copy link
Member

alikhajeh1 commented Sep 3, 2020

@sashman is already working on this, https://github.com/infracost/infracost-orb

@aliscott aliscott added the new integration New integration with external product/tool (CI/CD, code editor, etc) label Sep 9, 2020
@m-yosefpor
Copy link
Contributor

Now that we have docker image on dockerhub, can we just use that instead of building it in the orb file? @sashman

@m-yosefpor
Copy link
Contributor

I've created a PR for the above comment: infracost/infracost-orb#2

@sashman
Copy link
Contributor

sashman commented Sep 14, 2020

I'll take this

@sashman
Copy link
Contributor

sashman commented Sep 24, 2020

Working on infracost/infracost-orb#1 next

@alikhajeh1 alikhajeh1 self-assigned this Nov 19, 2020
@amioranza
Copy link

Hi, this issue has any updates? I'm really interested to integrate infracost at circleci.

@alikhajeh1
Copy link
Member Author

@amioranza yep! I've simplified the CI script so it can be re-used across GitHub, GitLab and CircleCI, the refactor will be merged today/tmrw and I'll update the orb to use it next right after that :)

@amioranza
Copy link

Awesome!!! Thanks.

@alikhajeh1
Copy link
Member Author

@amioranza this is now released, please see https://github.com/infracost/infracost-orb

  1. I added support for GitHub and BitBucket and tested using their cloud offerings, are you using one of these? I also added 2 envs that can be useful for self-hosted ones but I haven't tested those.
  2. If you're using BitBucket, please note that it does not show commit comments in the pull request page so you have to check the commit's comments page to see the Infracost output.

What's your take on infracost CI integrations storing the infracost output from the current branch as an artifact in the build, useful for future reference or is the diff comment enough?

I'll close the issue but feel free to comment to let me know how it goes.

@amioranza
Copy link

Hi @alikhajeh1:
First of all thanks for your works.

  1. We use github cloud. I'll integrate the new orb and test it.
  2. As bitbucket is not our current scenario, it is ok for me.

I think that infracost comment is enough, it we need to see the history we can go to the PR and look at the comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new integration New integration with external product/tool (CI/CD, code editor, etc)
Projects
None yet
Development

No branches or pull requests

5 participants