Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources migration t1 #1181

Closed
wants to merge 54 commits into from
Closed

Conversation

sinabakh
Copy link
Contributor

@sinabakh sinabakh commented Dec 4, 2021

No description provided.

@sinabakh
Copy link
Contributor Author

sinabakh commented Dec 4, 2021

Automatic resource migration proved to be harder than what I originally thought HAHA :))

However, it's getting somewhere. I'm pretty sure we can migrate around 60% of resources automatically, and probably we can achieve something near 90% with help of other members.

I'm doing a few tweaks to make all the 60% work and then we can discuss the challenges regarding the remaining 40%

PS. This PR is just a reference and there will be other PRs for the actual migrations.

@aliscott
Copy link
Member

aliscott commented Jan 3, 2022

@sinabakh is this PR up-to-date with the latest migrator script changes now?

@sinabakh
Copy link
Contributor Author

sinabakh commented Jan 3, 2022

@aliscott Yes it is.

@aliscott
Copy link
Member

aliscott commented Jan 3, 2022

Looks like it just needs some linting fix ups and then we can merge it?

@sinabakh
Copy link
Contributor Author

sinabakh commented Jan 3, 2022

Do we need to merge it? I just created this PR as a reference.
We can merge it to another branch so we can look at it for other migrations.

@sinabakh
Copy link
Contributor Author

sinabakh commented Jan 3, 2022

Also, it needs few other tweaks for remaining resources.

@aliscott
Copy link
Member

aliscott commented Jan 5, 2022

Do we need to merge it?

I don't have a strong opinion, but since it's fairly separate I thought it would be good to have it in the master branch, so we don't accidentally clean up the branch. But I'm happy either way.

@sinabakh
Copy link
Contributor Author

@aliscott Number 1 is fixed, however not so elegant. In the resource file it will always check the existence with: r.Foo != nil so we need to replace nil with the right thing manually.

@sinabakh
Copy link
Contributor Author

I'll close this PR since the discussions are all resolved and the process is in its final stages. (The few azure resources are left) So there's no need for this PR. However, I will keep the branch in my local fork.

@sinabakh sinabakh closed this Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants