Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws): Set engine for AWS DB Instance replica #1438

Merged
merged 2 commits into from
Mar 9, 2022
Merged

fix(aws): Set engine for AWS DB Instance replica #1438

merged 2 commits into from
Mar 9, 2022

Conversation

vdmgolub
Copy link
Contributor

@vdmgolub vdmgolub commented Mar 8, 2022 •
edited

Fixes #1436.

@vdmgolub vdmgolub marked this pull request as ready for review March 8, 2022 13:08
@vdmgolub vdmgolub requested a review from hugorut March 8, 2022 13:08
hugorut
hugorut approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@hugorut hugorut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - have we made sure that this works with a module setup like the user described?

@vdmgolub
Copy link
Contributor Author

vdmgolub commented Mar 8, 2022

@hugorut Good point, let me verify that before merging 👍

@vdmgolub vdmgolub mentioned this pull request Mar 9, 2022
Closed
@vdmgolub vdmgolub merged commit 39d5cba into master Mar 9, 2022
@vdmgolub vdmgolub deleted the fix/aws-db-instance-replica branch March 9, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugorut hugorut hugorut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HCL Parsing doesn't report aws_db_instance's cost when it's a replica
2 participants
@vdmgolub @hugorut