Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Google SQL Database Instance default values #1455

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

aliscott
Copy link
Member

  • When state was applied replica_configuration was set to an empty value, so this was adding a subresource for the replica when it shouldn't have been
  • A public v4 IP is added to the DB instances by default

* When state was applied `replica_configuration` was set to an empty value, so this was adding a subresource for the replica when it shouldn't have been
* A public v4 IP is added to the DB instances by default
@aliscott aliscott marked this pull request as ready for review March 14, 2022 11:44
@aliscott aliscott requested a review from hugorut March 14, 2022 11:44
@aliscott aliscott self-assigned this Mar 14, 2022
Copy link
Contributor

@hugorut hugorut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍾

@aliscott aliscott merged commit 67882d1 into master Mar 15, 2022
@aliscott aliscott deleted the fix/google-sql-database branch March 15, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants