Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add fig-autocomplete subcommand #1457

Merged
merged 2 commits into from
Mar 15, 2022
Merged

feat: add fig-autocomplete subcommand #1457

merged 2 commits into from
Mar 15, 2022

Conversation

fedeci
Copy link
Contributor

@fedeci fedeci commented Mar 13, 2022 •
edited

This does not completely close (#1118), but I am almost done with creating a GH action that will allow to automatically push new versions of the spec to the autocomplete repo and I will open another PR soon!

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@aliscott
Copy link
Member

Thanks @fedeci this looks great! I think it needs make test_update_cmd run to update the command golden file tests to fix the build.

@fedeci
Copy link
Contributor Author

fedeci commented Mar 14, 2022

Sure!

@aliscott aliscott self-requested a review March 15, 2022 16:14
@aliscott aliscott self-assigned this Mar 15, 2022
aliscott
aliscott approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@aliscott aliscott left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fedeci LGTM, I had a play around with this on fig and it works well!

One small question but it's not an issue for merging.

cmd/infracost/testdata/help/help.golden Show resolved Hide resolved
@aliscott aliscott merged commit 8e854e6 into infracost:master Mar 15, 2022
@fedeci fedeci deleted the add-fig-autocomplete branch March 15, 2022 16:59
@aliscott aliscott mentioned this pull request Mar 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliscott aliscott aliscott approved these changes

Assignees

@aliscott aliscott

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fedeci @CLAassistant @aliscott