fix: fix google_container_cluster duplicating node pools when applied #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `google_container_cluster` resource pulls all existing node pools into its `node_pool` attribute when deployed. This duplicates the default pool and any node pools defined in `google_container_node_pool` resources. To fix this we: 1. Only add the default node pool subresource if it doesn't already exist in the `node_pool` array. If it does exist in that array, we add it as part of that. 2. Check for node pools defined in other resources, and only add them as subresources if they are not.
aliscott
force-pushed
the
fix/deployed-container-cluster
branch
from
f29a762
to
ba6b975
Compare
7onn
reviewed
Mar 15, 2022
Comment on lines
+41
to
+48
| func contains(a []string, x string) bool { | ||
| for _, n := range a { | ||
| if x == n { | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } |
There was a problem hiding this comment.
When you guys update the Golang version to 1.18, there's this awesomely helpful package to employ such features: https://github.com/samber/lo
There was a problem hiding this comment.
Go 1.18 is out! 🎉 https://twitter.com/golang/status/1503787326060875782
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
google_container_clusterresource pulls all existing node pools into itsnode_poolattribute when deployed. This duplicates the default pool and any node pools defined ingoogle_container_node_poolresources. To fix this we:node_poolarray. If it does exist in that array, we add it as part of that.