feat: Add aws spot instance request #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for PR this @lucastercas, I'll take a peek at this when I get a moment in the next few days. |
hugorut
requested changes
Dec 14, 2022
There was a problem hiding this comment.
@lucastercas this looks great, thanks. However, we just need to change the way we test the output price. A golden file test won't work unfortunately. Thanks
...roviders/terraform/aws/testdata/spot_instance_request_test/spot_instance_request_test.golden
Outdated
Show resolved
Hide resolved
hugorut
reviewed
Dec 19, 2022
...roviders/terraform/aws/testdata/spot_instance_request_test/spot_instance_request_test.golden
Outdated
Show resolved
Hide resolved
hugorut
reviewed
Dec 20, 2022
...al/providers/terraform/aws/testdata/spot_instance_request_test/spot_instance_request_test.tf
Outdated
Show resolved
Hide resolved
...iders/terraform/aws/testdata/spot_instance_request_test/spot_instance_request_test.usage.yml
Outdated
Show resolved
Hide resolved
|
Any update on this? |
tim775
approved these changes
Mar 28, 2023
hugorut
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
aws_spot_instance_requestFixes: #1223