feat: wildcard support for modules in usage file #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aliscott I'm not sure what we're thinking of doing with the |
hugorut
force-pushed
the
feat/wildcard-modules
branch
from
ee09cf0
to
fcde5fe
Compare
hugorut
commented
Feb 8, 2023
hugorut
commented
Feb 8, 2023
hugorut
force-pushed
the
feat/wildcard-modules
branch
from
fcde5fe
to
15febbb
Compare
hugorut
force-pushed
the
feat/wildcard-modules
branch
from
15febbb
to
c37f8a8
Compare
This PR adds support for wildcard references in the Infracost usage file. Users can now specify usage file references such as `module.mod[*].aws_lambda_function.test[*]`. This functionality is enabled by the introduction of `schema.UsageMap` into the application. This builds a regexp from the usage file name (escaping all regular expression metacharacters apart from *) if a direct match is not made. This means we can support many layers of wildcard references, e.g: `module.mod[*].module.another[*].aws_lambda_function.test[*]`.
hugorut
force-pushed
the
feat/wildcard-modules
branch
3 times, most recently
from
4d651e4
to
2304330
Compare
hugorut
commented
Feb 13, 2023
| @@ -8,7 +8,7 @@ Project: infracost/infracost/cmd/infracost/testdata/breakdown_terraform_sync_usa | |||
| └─ Insights queries data scanned Monthly cost depends on usage: $0.005 per GB | |||
|
|
|||
| aws_cloudwatch_log_group.production_logs["media"] | |||
| ├─ Data ingested Monthly cost depends on usage: $0.50 per GB | |||
| ├─ Data ingested 1,000 GB $500.00 | |||
There was a problem hiding this comment.
This seems like this was a bug before that was fixed by this PR, the resource defaults are as follows:
resource_type_default_usage:
aws_cloudwatch_log_group:
monthly_data_ingested_gb: 1000.0
2304330
to
aee1996
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for wildcard references in the Infracost usage file.
Users can now specify usage file references such as
module.mod[*].aws_lambda_function.test[*].This functionality is enabled by the introduction of
schema.UsageMapinto the application. This builds a regexp from the usage file name (escaping all regular expression metacharacters apart from *) if a direct match is not made. This means we can support many layers of wildcard references, e.g:module.mod[*].module.another[*].aws_lambda_function.test[*].