Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show all errored project #2290

Merged
merged 1 commit into from
Feb 14, 2023
Merged

feat: show all errored project #2290

merged 1 commit into from
Feb 14, 2023

Conversation

hugorut
Copy link
Contributor

@hugorut hugorut commented Feb 13, 2023

This change removes the early exit in the CLI if all projects have errored. This means that the CLI output will always return a successful list of projects even if all of them have errored. This means that the output JSON will be generated correctly if all projects have errored. This change also removes the output table from the comment if there are no projects in the output JSON.

@hugorut hugorut self-assigned this Feb 13, 2023
This change removes the early exit in the CLI if all projects have errored. This means that the CLI output will always return a successful list of projects even if all of them have errored. This means that the output JSON will be generated correctly if all projects have errored. This change also removes the output table from the comment if there are no projects in the output JSON.
Copy link
Member

@aliscott aliscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugorut hugorut merged commit 0e939a7 into master Feb 14, 2023
@hugorut hugorut deleted the feat/no-error-runs branch February 14, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants