fix: prevent expanding dynamic blocks injecting more than once #2291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue where dynamic blocks add duplicate expanded blocks into the
childBlocks
of the parent module. For example:Take the following root module definition:
which calls out to a module with the following terraform:
Prior to this change the
length
ofchild_block
would be 4 instead of the expected 2. This is because on first evaluationdata.bad_state.bad.my_bad["10.0.0.0/24"].id
isnull
and then on second evaluation we mock it. This means that we "reload" the underlying modulebaz
which expands thechild_block
again. The second expansion simply injects two more blocks intochildBlocks
without clearing the prior expanded blocks.We now
RemoveBlocks
of all type beforeInjectBlock
so any prior expanded blocks will be overwritten.