Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(azure): add support for PowerBI Embedded #2306

Merged
merged 4 commits into from
Feb 22, 2023

Conversation

aliscott
Copy link
Member

No description provided.

@aliscott aliscott self-assigned this Feb 21, 2023
@aliscott aliscott marked this pull request as ready for review February 22, 2023 10:19
@aliscott aliscott requested a review from tim775 February 22, 2023 10:19
Copy link
Member

@tim775 tim775 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We probably should make it the new-style "CoreResource"

internal/providers/terraform/azure/powerbi_embedded.go Outdated Show resolved Hide resolved
internal/providers/terraform/azure/powerbi_embedded.go Outdated Show resolved Hide resolved
internal/resources/azure/powerbi_embedded.go Show resolved Hide resolved
aliscott and others added 3 commits February 22, 2023 14:27
Co-authored-by: Tim McFadden <52185+tim775@users.noreply.github.com>
@aliscott aliscott merged commit e3bcadc into master Feb 22, 2023
@aliscott aliscott deleted the feat/add-azure-powerbi-embedded branch February 22, 2023 17:36
robh007 pushed a commit to robh007/infracost that referenced this pull request Feb 27, 2023
* feat(azure): add support for PowerBI Embedded

* Apply suggestions from code review

Co-authored-by: Tim McFadden <52185+tim775@users.noreply.github.com>

* fix: fix function signature

* chore: fmt

---------

Co-authored-by: Tim McFadden <52185+tim775@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants