Add MSSQL Elastic Pool #2310
Merged
Add MSSQL Elastic Pool #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliscott
force-pushed
the
feat/add-mssql-elastic-pool
branch
7 times, most recently
from
d9da5a3
to
542c05d
Compare
aliscott
force-pushed
the
feat/add-mssql-elastic-pool
branch
from
542c05d
to
34d858a
Compare
hugorut
approved these changes
Feb 27, 2023
| @@ -0,0 +1,42 @@ | |||
| package azure | |||
There was a problem hiding this comment.
Do we need this file - it doesn't look like we use it?
…dundancy * Zone redundancy costs are additional, not instead of the existing compute cost, so this adds them as a separate cost component. * We don't need to show the extra data costs if there's no extra data usage. This only applies if provisioned. i thik we can get rid of the usage parameter for this but will do that separately.
aliscott
force-pushed
the
feat/add-mssql-elastic-pool
branch
from
e49428c
to
a4fd94e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the
azurerm_mssql_elasticpoolresource and the deprecatedazurerm_sql_elasticpoolresource.It also fixes some issues with the existing
azurerm_mssql_databaseresource:I think we can remove the
extra_data_storage_gbusage param fromazurerm_mssql_databasesince its value is always defined in Terraform. I haven't done that as part of this PR though.