feat: Add support for Azure Monitor Log Alerts (scheduled query rules alerts) #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdmgolub
approved these changes
Mar 16, 2023
internal/providers/terraform/azure/monitor_scheduled_query_rules_alert_v2.go
Outdated
Show resolved
Hide resolved
| freq = int64(ef.ToDuration().Minutes()) | ||
| } | ||
|
|
||
| scopeCount := 1 // default scope is the azure subscription, so count == 1 |
There was a problem hiding this comment.
Suggested change
| scopeCount := 1 // default scope is the azure subscription, so count == 1 | |
| scopeCount := 1 // default scope is the Azure subscription, so count == 1 |
internal/providers/terraform/azure/monitor_scheduled_query_rules_alert_v2.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
We should drop this file if we don't have usage params.
There was a problem hiding this comment.
Same comment here to remove the redundant file.
internal/resources/azure/monitor_scheduled_query_rules_alert.go
Outdated
Show resolved
Hide resolved
tim775
force-pushed
the
feat/add_azure_monitor_scheduled_query_rules_alert
branch
from
cc7056c
to
3bf5dfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.