Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Azure storage costs (BlobStorage, StorageV1, QueueStorage) #2362

Merged
merged 9 commits into from
Mar 23, 2023
Merged

Add Azure storage costs (BlobStorage, StorageV1, QueueStorage) #2362

merged 9 commits into from
Mar 23, 2023

Conversation

aliscott
Copy link
Member

@aliscott aliscott commented Mar 17, 2023 •
edited

  • Adds BlobStorage costs
  • Adds Storage v1 costs
  • Adds Queue Storage costs with support for Storage v1 and Storage v2 accounts

@aliscott aliscott self-assigned this Mar 17, 2023
@aliscott aliscott force-pushed the add-new-storage branch 3 times, most recently from a0123af to 6d902ad Compare March 22, 2023 13:26
@aliscott aliscott force-pushed the add-new-storage branch 3 times, most recently from 29d448d to 531a3ae Compare March 22, 2023 20:59
@aliscott aliscott changed the title Add Azure storage costs Add Azure storage costs (BlobStorage, StorageV1, QueueStorage) Mar 23, 2023
@aliscott aliscott requested a review from hugorut March 23, 2023 12:34
@aliscott aliscott marked this pull request as ready for review March 23, 2023 12:35
hugorut
hugorut approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@hugorut hugorut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've tested a few of the components with the pricing calculator and it checks out, but I have not done exhaustively

internal/providers/terraform/azure/testdata/storage_account_test/storage_account_test.tf Show resolved Hide resolved
internal/providers/terraform/azure/testdata/storage_queue_test/storage_queue_test.tf Show resolved Hide resolved
internal/providers/terraform/azure/storage_queue.go Show resolved Hide resolved
internal/resources/azure/storage_queue.go Outdated Show resolved Hide resolved
internal/resources/azure/storage_queue.go
}

if validReplicationTypes != nil {
return contains(validReplicationTypes, strings.ToUpper(r.AccountReplicationType))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer map lookup but this probs reads better

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping this consistent with the existing storage account code.

@aliscott aliscott merged commit 338814b into master Mar 23, 2023
@aliscott aliscott deleted the add-new-storage branch March 23, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugorut hugorut hugorut approved these changes

Assignees

@aliscott aliscott

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aliscott @hugorut