Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(azure): add support for Storage File Shares #2373

Merged
merged 3 commits into from
Mar 28, 2023

Conversation

aliscott
Copy link
Member

@aliscott aliscott commented Mar 27, 2023

This adds support for Azure File Shares. There's some overlap with azurerm_storage_account when account_kind = FileStorage, but I think that's okay since there's more flexibility with what they can do with azure_storage_share and we shouldn't break backwards compatibility. Everything can be adjusted with the usage file to make sure one resource get the cost.

There's also some overlapping logic with this and azurerm_storage_account but I decided to keep it separate for just now - unpicking the azurerm_storage_account resource was getting a bit messy.

@aliscott aliscott self-assigned this Mar 27, 2023
@aliscott aliscott marked this pull request as ready for review March 27, 2023 19:10
@aliscott aliscott requested a review from hugorut March 27, 2023 19:10
@hugorut hugorut merged commit 05f9e27 into master Mar 28, 2023
@hugorut hugorut deleted the feat/azure-storage-share branch March 28, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants