Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for mssql_managed_instance #2393

Merged
merged 4 commits into from
Apr 25, 2023
Merged

Conversation

grixxie
Copy link
Contributor

@grixxie grixxie commented Apr 2, 2023

addressing issue: #2063

infracost currently supports the "deprecated" sql_managed_instance -> add support for new mssql_managed_instance

any feedback appreciated

@grixxie
Copy link
Contributor Author

grixxie commented Apr 15, 2023

@tim775 I think this is ready for review - I would appreciate some feedback / some guidance on what else is left to do here

Copy link
Member

@tim775 tim775 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grixxie this is great!
I left a few mostly style comments.
Also we need to add the usage parameters to the example usage file.

Let me know if you have time to make the changes, otherwise I'm happy to finish them off.
Cheers,
Tim

internal/resources/azure/mssql_managed_instance.go Outdated Show resolved Hide resolved
internal/resources/azure/mssql_managed_instance.go Outdated Show resolved Hide resolved
internal/resources/azure/mssql_managed_instance.go Outdated Show resolved Hide resolved
internal/resources/azure/mssql_managed_instance.go Outdated Show resolved Hide resolved
@grixxie
Copy link
Contributor Author

grixxie commented Apr 24, 2023

Thanks for this @tim775 , I will make these changes including the example usage file :)

@tim775 tim775 added new resources New cloud resources to be added azure Issue relates to Microsoft Azure labels Apr 24, 2023
@grixxie grixxie requested a review from tim775 April 25, 2023 10:40
Copy link
Member

@tim775 tim775 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! If you would, please update the golden file test to pick up the changes by running:

ARGS="--run TestMSSQLManagedInstance -v -update" make test_azure

@tim775 tim775 merged commit 83df543 into infracost:master Apr 25, 2023
8 of 9 checks passed
@grixxie
Copy link
Contributor Author

grixxie commented Apr 25, 2023

Hey @tim775 , I'm still pretty new to this so I'd appreciate some help here - running make test_azure with the above commands is failing and the golden test file produced is showing all $0.00's.

I've followed the steps in CONTRIBUTING.md including the azure-credentials section but still no luck. I'm unsure whether it's a problem with my code changes or my local setup at this point - maybe you can help?

Apologies, still getting into this 😆

@tim775
Copy link
Member

tim775 commented Apr 26, 2023

@grixxie, no worries I actually ended up merging this with the intention of updating the golde file test after and ran into the same issue you're seeing now. It looks like the filters got messed up somehow, but it was a quick fix.

@grixxie
Copy link
Contributor Author

grixxie commented Apr 26, 2023

@tim775 ah brilliant, this works for me now, thank you!

@grixxie grixxie deleted the fix/2063 branch April 26, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure Issue relates to Microsoft Azure new resources New cloud resources to be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants