feat: default variables for infracost config template files #2394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for default data to be passed into the template parser. This allows up to provide top level metadata variables that users can interact with. Currently the only supported variable is `.branch` which represents the current branch name of the repo, e.g. `main`, `test`.
vdmgolub
approved these changes
Apr 3, 2023
Co-authored-by: Vadim Golub <vadim@infracost.io>
aliscott
reviewed
Apr 3, 2023
| @@ -22,13 +22,15 @@ var ( | |||
| type Parser struct { | |||
| repoDir string | |||
| template *template.Template | |||
| data map[string]interface{} | |||
There was a problem hiding this comment.
@hugorut is there any benefit to making this a struct with types instead of a map of interfaces? Does it help if we want to pass these variables into other template functions in the future?
hugorut
added a commit
that referenced
this pull request
Apr 25, 2023
hugorut
added a commit
that referenced
this pull request
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for default data to be passed into the template parser. This allows up to provide top level metadata variables that users can interact with. Currently the only supported variable is
.branchwhich represents the current branch name of the repo, e.g.main,test.