feat: Add support for Azure SignalR Service #2399
Conversation
| name = each.value | ||
| capacity = 5 | ||
| } | ||
| } |
There was a problem hiding this comment.
Let's fix this missing newline here. Otherwise, when the next person opens this file in the editor and saves it, it will be added, resolving in a git diff line.
There was a problem hiding this comment.
I hear you (though for whatever reason goland doesn't do that) but I feel like these kind of style issues should be addressed through code (i.e. make fmt) not code reviews. There are over 100 .tf files without trailing newline and for whatever reason terraform fmt doesn't want to enforce this but I think it should be easy enough to right a find + awk that does it so I'll do that in a separate pr.
| monthly_additional_messages: 1234567 | ||
|
|
||
| azurerm_signalr_service.example_with_usage["Premium_P1"]: | ||
| monthly_additional_messages: 12345678 |
| // See providers folder for more information. | ||
| func (r *SignalRService) BuildResource() *schema.Resource { | ||
| // normalize sku to first letter capitalized | ||
| sku := cases.Title(language.English).String(strings.ToLower(r.SkuName)) |
There was a problem hiding this comment.
It might be a great candidate to become a new helper function. I see it's used in several places already. :)
No description provided.