Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gcp): add iops & extend google_compute_disk to include pd-extreme and hyperdisk-extreme #2408

Merged
merged 8 commits into from
Apr 25, 2023

Conversation

hash-sha512
Copy link
Contributor

@hash-sha512 hash-sha512 commented Apr 15, 2023

Objective:

Add support for google_compute_disk - IOPS and pd-extreme and hyperdisk-extreme. Fixes #2403 .

Pricing details:

Pricing Reference

Status:

  • Generated the resource files - N/A
  • Updated the internal/resources file
  • Updated the internal/provider/terraform/.../resources file
  • Added usage parameters to infracost-usage-example.yml - N/A
  • Added test cases without usage-file
  • Added test cases with usage-file - N/A
  • Compared test case output to cloud cost calculator
  • Created a PR to update "Supported Resources" in the docs - N/A

Issues:

None

@hash-sha512 hash-sha512 marked this pull request as draft April 16, 2023 11:23
@hash-sha512 hash-sha512 marked this pull request as ready for review April 16, 2023 14:24
@hash-sha512
Copy link
Contributor Author

The commit a6aeeb8 has updated 3 golden test files
i have manually verified with cost calculator for compute_disk.
But, make test_update_google has also updated container_registry and storage_bucket. I am not sure of these two.

@hash-sha512
Copy link
Contributor Author

@aliscott Tests are currently failing for Nvidia T80 (preemptible) and Network egress. The PR doesn't directly influence this. How do I proceed?

@aliscott
Copy link
Member

@aliscott Tests are currently failing for Nvidia T80 (preemptible) and Network egress. The PR doesn't directly influence this. How do I proceed?

It looks like that's failing just now on master as well, so it shouldn't affect this.

@aliscott
Copy link
Member

Thanks @hash-sha512, this looks great 🙏

@aliscott aliscott merged commit e701d52 into infracost:master Apr 25, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

infracost breakdown for pd-extreme gives estimates for pd-standard (google_compute_disk)
2 participants