fix: support name as a global aws resource ref #2409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliscott
approved these changes
Apr 17, 2023
This PR adds support to use `name` as a global resource reference. This resolves issues with resources that reference dependent resources with `name`. For example aws_autoscaling_group.launch_configuration:
```
resource "aws_autoscaling_group" "asg_lc_min_size_name_ref" {
launch_configuration = aws_launch_configuration.lc_basic.name
max_size = 3
min_size = 2
}
```
Prior to this change `asg_lc_min_size_name_ref` would have blank references. I've decided to put move the `name` into the default resource ID func as I believe referencing a resource by `name` is probably quite a common pattern across a wide range of resources.
hugorut
force-pushed
the
feat/support-name-refs
branch
from
d0ce96c
to
d06b125
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to use
nameas a global resource reference. This resolves issues with resources that reference dependent resources withname. For example aws_autoscaling_group.launch_configuration:Prior to this change
asg_lc_min_size_name_refwould have blank references. I've decided to put move thenameinto the default resource ID func as I believe referencing a resource bynameis probably quite a common pattern across a wide range of resources.