Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws): add opensearch support #2415

Merged
merged 2 commits into from
Apr 27, 2023
Merged

feat(aws): add opensearch support #2415

merged 2 commits into from
Apr 27, 2023

Conversation

ABaboshin
Copy link
Contributor

Addressing issue #1981

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@hugorut hugorut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's just remove the duped OpensearchDomain. Seems that the tests are also failing as they've been copied over from the elastic search ones. Could we update the terraform and golden file output. Thanks

internal/resources/aws/opensearch_domain.go Outdated Show resolved Hide resolved
@hugorut hugorut self-requested a review April 27, 2023 07:38
Copy link
Contributor

@hugorut hugorut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ABaboshin, I've made some minor tweaks to this as we wanted to get this into the release today. Thank you for your help in adding OpenSearch support 🚀

@hugorut hugorut merged commit 37c4742 into infracost:master Apr 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants