-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azure Network Watcher #2425
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliscott
force-pushed
the
feat/add-azure-network-watcher
branch
from
April 25, 2023 17:37
953a3fb
to
2471ee8
Compare
aliscott
force-pushed
the
feat/add-azure-network-watcher
branch
from
April 25, 2023 17:54
2471ee8
to
50ea289
Compare
aliscott
force-pushed
the
feat/add-azure-network-watcher
branch
from
April 25, 2023 17:59
50ea289
to
fbd3319
Compare
hugorut
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Comment on lines
+12
to
+29
// NetworkConnectionMonitor struct represents Azure Network Watcher Connection | ||
// Monitor (new) | ||
// | ||
// This resource is charged for each test. Connection Monitors can have | ||
// multiple test groups. A test is a combination of a source endpoint, | ||
// destination endpoint and test configuration within a test group. The number | ||
// of tests is calculated by multiplying the number of source endpoints, | ||
// destination endpoints and test configurations for each enabled test group. | ||
// | ||
// There is a free limit of 1000 tests. | ||
// | ||
// If the test configuration is for a scale set, then each instance of that | ||
// scale set counts as a separate test. Since we can't get the number of | ||
// instances in each scale set we allow the `tests` attribute to be overridden | ||
// in the usage file. | ||
// | ||
// Resource information: https://azure.microsoft.com/en-gb/pricing/details/network-watcher/#overview | ||
// Pricing information: https://azure.microsoft.com/en-gb/pricing/details/network-watcher/#pricing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦾
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1255