Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure Network Watcher #2425

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Add Azure Network Watcher #2425

merged 3 commits into from
Apr 26, 2023

Conversation

aliscott
Copy link
Member

@aliscott aliscott commented Apr 25, 2023

Closes #1255

@aliscott aliscott self-assigned this Apr 25, 2023
@aliscott aliscott marked this pull request as draft April 25, 2023 17:30
@aliscott aliscott force-pushed the feat/add-azure-network-watcher branch from 953a3fb to 2471ee8 Compare April 25, 2023 17:37
@aliscott aliscott force-pushed the feat/add-azure-network-watcher branch from 2471ee8 to 50ea289 Compare April 25, 2023 17:54
@aliscott aliscott force-pushed the feat/add-azure-network-watcher branch from 50ea289 to fbd3319 Compare April 25, 2023 17:59
@aliscott aliscott requested a review from hugorut April 25, 2023 18:38
@aliscott aliscott marked this pull request as ready for review April 25, 2023 18:38
Copy link
Contributor

@hugorut hugorut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

Comment on lines +12 to +29
// NetworkConnectionMonitor struct represents Azure Network Watcher Connection
// Monitor (new)
//
// This resource is charged for each test. Connection Monitors can have
// multiple test groups. A test is a combination of a source endpoint,
// destination endpoint and test configuration within a test group. The number
// of tests is calculated by multiplying the number of source endpoints,
// destination endpoints and test configurations for each enabled test group.
//
// There is a free limit of 1000 tests.
//
// If the test configuration is for a scale set, then each instance of that
// scale set counts as a separate test. Since we can't get the number of
// instances in each scale set we allow the `tests` attribute to be overridden
// in the usage file.
//
// Resource information: https://azure.microsoft.com/en-gb/pricing/details/network-watcher/#overview
// Pricing information: https://azure.microsoft.com/en-gb/pricing/details/network-watcher/#pricing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦾

@aliscott aliscott merged commit 0e1ef57 into master Apr 26, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Azure network watch flow logs
2 participants