refactor: various tweaks to comment and table format for CI/CLI #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hugorut
commented
Jun 15, 2023
hugorut
commented
- refactors markdown templates into tmpl files
- changes CI comment format, including table column change.
- adds new flags to comment to support new formatting for CI comment
- changes CLI diff summary to be inline with CI comment changes
- adds summary table to breakdown
hugorut
force-pushed
the
refactor/comment
branch
2 times, most recently
from
98424d9
to
305b220
Compare
hugorut
force-pushed
the
refactor/comment
branch
from
305b220
to
cab30cd
Compare
aliscott
reviewed
Jun 19, 2023
Comment on lines
+316
to
+318
| project.Name = strings.ReplaceAll(project.Name, tfdir, t.Name()) | ||
| project.Name = strings.ReplaceAll(project.Name, "/Terraform_CLI", "") | ||
| project.Name = strings.ReplaceAll(project.Name, "/HCL", "") |
hugorut
force-pushed
the
refactor/comment
branch
from
844ed2e
to
8b80f5f
Compare
aliscott
approved these changes
Jun 19, 2023
hugorut
force-pushed
the
refactor/comment
branch
from
8b80f5f
to
595d3a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.